Skip to content

Github cli - Adds retry logic for find git tags - #310

Merged
Samruddhi Khandale (samruddhikhandale) merged 4 commits into
mainfrom
samruddhikhandale/github-cli
Nov 30, 2022
Merged

Github cli - Adds retry logic for find git tags#310
Samruddhi Khandale (samruddhikhandale) merged 4 commits into
mainfrom
samruddhikhandale/github-cli

Conversation

@samruddhikhandale

Copy link
Copy Markdown
Member

Closes - #259

and Fixes find_prev_version_from_git_tags() for Nix feature - scenario: finding latest previous major release.

Comment thread src/github-cli/install.sh

@joshspicer joshspicer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered approaching from the other angle, and contributing back a change to the cli/cli repo with something like Chuck Lantz (@Chuxel) recommended here: #259 (comment) ?

Assuming they accept the contribution, that might make our Feature significantly simpler and easier to maintain/debug in the future?

Comment thread src/nix/utils.sh
Comment thread src/nix/utils.sh
Comment thread src/github-cli/install.sh Outdated
Comment thread src/github-cli/install.sh
@samruddhikhandale

Copy link
Copy Markdown
Member Author

Have you considered approaching from the other angle, and contributing back a change to the cli/cli repo with something like @Chuxell recommended here: #259 (comment) ?

Assuming they accept the contribution, that might make our Feature significantly simpler and easier to maintain/debug in the future?

I'll take a look 👀 in the meanwhile can we merge this? I'll cleanup once we have this update in cli/cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants